RFR: 8366364: Return enabled signature schemes with SSLConfiguration#getSSLParameters() call [v8]
Artur Barashev
abarashev at openjdk.org
Fri Oct 31 17:24:05 UTC 2025
On Fri, 31 Oct 2025 17:16:01 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Signatures schemes using sha224 are not available on Windows
>
> src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 424:
>
>> 422: for (String name : config.signatureSchemes) {
>> 423: var ss = SignatureScheme.nameOf(name);
>> 424: if (ss != null) {
>
> The previous code (in `namesOfAvailable()`) also checked if the scheme was available before adding it. Did you remove that check because it was redundant as the next loop checks that?
Yes, it is redundant, we check it below anyhow.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27961#discussion_r2482175352
More information about the security-dev
mailing list