RFR: 8343232: PKCS#12 KeyStore support for RFC 9579: Use of Password-Based Message Authentication Code 1 (PBMAC1)

Valerie Peng valeriep at openjdk.org
Wed Sep 3 01:24:51 UTC 2025


On Fri, 11 Jul 2025 19:53:41 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/PBMAC1Parameters.java line 146:
>> 
>>> 144:         }
>>> 145:         ObjectIdentifier OID = Info[1].data.getOID();
>>> 146:             KnownOIDs o = KnownOIDs.findMatch(OID.toString());
>> 
>> nit: indentation seems off?
>
> fixed

The indentation still doesn't look right... Line 139 should align with line 138? Same goes for line 140-150.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2317535622


More information about the security-dev mailing list