RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java [v2]
Fernando Guallini
fguallini at openjdk.org
Fri Sep 5 10:34:34 UTC 2025
On Fri, 5 Sep 2025 09:20:19 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> LGTM. The removal of useless test cases isn't strictly necessary. The test cases that don't lose any messages usually complete under a second. If you really want to remove all useless cases, add an assertion that needPacketLoss is false at the end of the test.
>
> If you want to improve the run time even further, this test doesn't really need to use a DatagramSocket. With some effort it could be rewritten to exchange ByteBuffers directly between the SSLEngines, similar to what is done in [`test/jdk/javax/net/ssl/templates/SSLEngineTemplate.java`](https://github.com/openjdk/jdk/blob/9c06dcb4396c3307d625663d92c0e11d794a56ea/test/jdk/javax/net/ssl/templates/SSLEngineTemplate.java). Then you wouldn't need to wait for the timeout to expire, and instead you could retransmit the packets immediately after dropping them, or after making sure that the peer doesn't act.
Thank you for the review.
I have now removed all useless cases, keeping only the ones that do actually lose messages.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27093#issuecomment-3257872892
More information about the security-dev
mailing list