RFR: 8366833: Poly1305 does not always correctly update position for array-backed ByteBuffers after processMultipleBlocks [v5]
Jamil Nimeh
jnimeh at openjdk.org
Thu Sep 11 00:54:04 UTC 2025
> This fix resolves an issue where the `Cipher.updateAAD(ByteBuffer)` method, when used on a ChaCha20-Poly1305 Cipher, may throw an exception due to an offset calculation error. This occurs when the ByteBuffer is array-backed, and when the buffer passed into the method is a slice of another array-backed buffer and that slice begins at a non-zero offset in the parent ByteBuffer.
>
> Credit and thanks to @jaikiran for finding the issue and providing reproducer code.
Jamil Nimeh has updated the pull request incrementally with one additional commit since the last revision:
Add tests for encryption correctness, also add tests for MemorySegment ByteBuffers
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27081/files
- new: https://git.openjdk.org/jdk/pull/27081/files/43cc8ca2..10e7e1f5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27081&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27081&range=03-04
Stats: 116 lines in 1 file changed: 67 ins; 6 del; 43 mod
Patch: https://git.openjdk.org/jdk/pull/27081.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27081/head:pull/27081
PR: https://git.openjdk.org/jdk/pull/27081
More information about the security-dev
mailing list