RFR: 8343395: SSLLogger doesn't work for formatted messages [v4]
Weijun Wang
weijun at openjdk.org
Wed Sep 17 21:06:49 UTC 2025
On Wed, 27 Aug 2025 10:25:00 GMT, Sean Coffey <coffeys at openjdk.org> wrote:
>> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug mode)
>>
>> SSL Debug messages don't use format specifiers. As a result, any custom format data isn't printed. Proposed solution is to append the SSL custom format output to the original debug message. Similar approach used for `SSLConsoleLogger ` mode.
>>
>> Used this opportunity to delete some old commented code and to replace use of `"\n"` with `System.lineSeparator()`
>>
>> DebugPropertyValuesTest also updated to test new logic.
>
> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into 8343395-formatter
> - Merge branch 'master' into 8343395-formatter
> - Merge branch 'master' into 8343395-formatter
> - Text Blocks use \n by default
> - 8343395
Does this mean the `parameters` argument in the `SSLSimpleFormatter::format` method is always empty? And then all those `messageCompactFormatWithParas` and `messageFormatWithParas` are useless?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25934#issuecomment-3304559320
More information about the security-dev
mailing list