RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v4]

[Mark Powers]

On Fri, 11 Jul 2025 19:47:57 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java line 231:
>> 
>>> 229: 
>>> 230:         var kdfParams = new PBKDF2Parameters();
>>> 231:         String kdfAlgo = kdfParams.parseKDF(kdf);
>> 
>> nit: `parseKDF()` seems a bit redundant as the KDF name is already in the class name, i.e. `PBKDF2Parameter`. Maybe name it `init()` as this is what it does, i.e. initialize the `PBKDF2Parameters` obj w/ the `DerValue` argument.
>
> fixed

After more review comments, this was replaced with a `PBKDF2Parameters(kdf)` constructor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2365627350