RFR: 8343395: SSLLogger doesn't work for formatted messages [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Mon Sep 22 12:54:30 UTC 2025
On Mon, 22 Sep 2025 10:06:15 GMT, Sean Coffey <coffeys at openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/ssl/Utilities.java line 154:
>>
>>> 152: StringBuilder builder = new StringBuilder();
>>> 153: if (source == null) {
>>> 154: builder.append(LINE_SEP).append(prefix).append("<blank message>");
>>
>> I don't think this ls covered by the test. Could you please add an empty case to cover this?
>
> @myankelev I didn't see any code in the JDK calling this method with `source == null`. Other than hacking into the internals of SSLLogger to force the method call, I'm not sure it can be covered. Would you be ok to log a follow on task/bug if you feel coverage of this corner case is warranted ? Thanks.
I think this could be rolled under this https://bugs.openjdk.org/browse/JDK-8361344. So I'm not sure it needs a separate ticket.
If there is not easy way of covering it here, I think this could be addressed in JDK-8361344
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25934#discussion_r2368222667
More information about the security-dev
mailing list