RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip
Mikhail Yankelevich
myankelevich at openjdk.org
Wed Sep 24 10:29:37 UTC 2025
On Mon, 22 Sep 2025 15:56:11 GMT, Weijun Wang <weijun at openjdk.org> wrote:
> Honestly, I don't quite understand why there are 2 tests initializing `skipTest` as true and then assign it false. Usually it's the other way round. If you know why it has to be coded this way, please add some comments there. Thanks.
I was just keeping the previous logic that was present before and could be seen in the other files.
I personally don't think flipping the logic will bring any benefits. Especially as it may bring accidental confusion if several tests with flipped and not flipped logic are involved in some fix/enhancement in the future.
But overall I'm fine with doing this, so if you think I should - I will.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27367#issuecomment-3327659645
More information about the security-dev
mailing list