RFR: 8374808: Add new methods to KeyStore and KeyStoreSpi that return the creation date as an Instant instead of Date [v8]
Mikhail Yankelevich
myankelevich at openjdk.org
Mon Feb 9 21:28:41 UTC 2026
On Thu, 5 Feb 2026 21:26:47 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> I'd personally prefer to keep it this way as when it was inline it was really hard to read for me. If you feel strongly about it - I can change it :)
>
> No problem. In fact, I see on line 2440 of `PKCS12KeyStore` you have
>
> instant = Instant.ofEpochMilli(
> Long.parseLong(keyIdStr.substring(5)));
>
> So I thought you're OK to either style.
Actually, I just missed this, changed in the next commit. Hope it looks good to you
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2775009895
More information about the security-dev
mailing list