RFR: 8377318: Force bad padding exception in TestPKCS5PaddingError.java at all times

Valerie Peng valeriep at openjdk.org
Thu Feb 12 22:03:44 UTC 2026


On Thu, 12 Feb 2026 11:57:52 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> You already print out the byte[] (even though I wonder how useful this can be when you don't have the dynamically generated key value, maybe something to print out also?), doing the "new String(result)" part does not seem useful as it's just a bunch of Unicode characters. Not sure what kind of purpose it's for.
>
> It was just handy to see if the text is the same in testing. I expect it to help in reading the logs a bit. I don't mind removing it. 
> How about I change it to the if statement checking if `new String(result)` quals initial text and if it is print a separate log? This seems to me a bit cleaner

Well, print it out separately is better than what you have now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29612#discussion_r2801267901



More information about the security-dev mailing list