RFR: 8377318: Force bad padding exception in TestPKCS5PaddingError.java at all times [v2]
Valerie Peng
valeriep at openjdk.org
Tue Feb 17 19:25:16 UTC 2026
On Fri, 13 Feb 2026 11:22:27 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Currently implementation of the test relies on changing the last byte of the cypher to mess up the padding lines. However if the last bit is already 0 the padding will not be taken into account and the result will have no error but will be a garbage output. Current test doesn't take this into account.
>>
>> The fix should encode the test text without padding and decode with padding to make sure that the bad padding exception is thrown.
>>
>> Kudos to @djelinski for assisting with finding the issue vs RFC!
>>
>> Also added a bug id which was missing
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>
> changed warning
Marked as reviewed by valeriep (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/29612#pullrequestreview-3815841083
More information about the security-dev
mailing list