RFR: 8376164: Optimize AES/ECB/PKCS5Padding implementation using full-message intrinsic stub and parallel RoundKey addition [v2]

[xinyangwu]

On Thu, 19 Feb 2026 03:00:27 GMT, Shawn Emery <semery at openjdk.org> wrote:

>> xinyangwu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into aes
>>  - 8376164: Optimize AES/ECB/PKCS5Padding with parallel intrinsic
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1449:
> 
>> 1447:     __ opc(xmm_result2, reg); \
>> 1448:     __ opc(xmm_result3, reg); \
>> 1449:   } while (0)
> 
> Can't this just be?:
> #define DoFour(opc, reg)   \
> __ opc(xmm_result0, reg); \
> __ opc(xmm_result1, reg); \
> __ opc(xmm_result2, reg); \
> __ opc(xmm_result3, reg); \

Sorry for the late reply. This is to make the macro expand to a single statement, avoiding dangling‑else problems and allowing a semicolon after it. However, this scenario doesn't seem to have occurred. To maintain consistency with the overall coding style, I've made modifications.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2844622079