RFR: 8376164: Optimize AES/ECB/PKCS5Padding implementation using full-message intrinsic stub and parallel RoundKey addition [v2]
Shawn Emery
semery at openjdk.org
Tue Feb 24 08:18:57 UTC 2026
On Tue, 24 Feb 2026 05:46:11 GMT, xinyangwu <duke at openjdk.org> wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1404:
>>
>>> 1402: }
>>> 1403:
>>> 1404: address StubGenerator::generate_electronicCodeBook_encryptAESCrypt_multiBlock_Parallel() {
>>
>> Would be nice to have a method description (input, outputs, which registers are used on which platforms) and the overall algorithm used for multi-block encryption/decryption.
>
> Thank you for your review. I've added input and output descriptions similar to other methods, but I noticed that those methods didn't provide the overall algorithms. I'll add them if you think it's necessary.
What you have added is inline with the existing comments for these methods, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2845228543
More information about the security-dev
mailing list