RFR: 8373515: Migrate "test/jdk/java/net/httpclient/" to null-safe "SimpleSSLContext" methods [v4]
Volkan Yazici
vyazici at openjdk.org
Tue Jan 6 09:01:25 UTC 2026
On Tue, 6 Jan 2026 06:26:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into simpleSslHc
>> - Merge remote-tracking branch 'upstream/master' into simpleSslHc
>> - Make sure `get()` returns the same instance
>> - Restore `test/jdk/java/net/httpclient/` changes
>> - Reverted all changes and only kept `SimpleSSLContext` enhancements
>> - Overhaul `SimpleSSLContext` and its usages
>
> test/jdk/java/net/httpclient/ALPNProxyFailureTest.java line 47:
>
>> 45: public class ALPNProxyFailureTest extends ALPNFailureTest {
>> 46:
>> 47: private static final SSLContext context = SimpleSSLContext.findSSLContext();
>
> Hello Volkan, there seems to be an oversight here - as far as I can see, the call to `SSLContext.setDefault(context)` is no longer being done after this change.
Doh! :facepalm: Fixed in 3204e85f57e.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28771#discussion_r2664167892
More information about the security-dev
mailing list