RFR: 8367326: Refactor PEM API tests requiring PEMRecord usage
Mikhail Yankelevich
myankelevich at openjdk.org
Wed Jan 7 11:45:04 UTC 2026
On Thu, 27 Nov 2025 01:41:46 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
> I understand the intent to use `PEM` here, but I think this is forcing the new API onto these tests rather than making it easier. For `TestKeyFactory.java` I wouldn't make the change. For the other two, I think it makes more sense to headers and footers to the base64 strings than using `PEM` to workaround it.
Yes, I think this should be easier. However, I'd have to disagree about `PKIXValAndRevCheckTests.java`. I use it intentionally there like this in order to increase the coverage of the PEM::decode method.
What do you think about keeping it as is and changing `PSSKeyCompatibility` in order not to force PEM?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28356#issuecomment-3718493332
More information about the security-dev
mailing list