RFR: 8360934: Add AVX-512 intrinsics for ML-KEM - enhancement on AVX512_VBMI and AVX512_VBMI2 [v2]
Volodymyr Paprotski
vpaprotski at openjdk.org
Wed Jan 7 16:42:27 UTC 2026
On Wed, 7 Jan 2026 06:18:55 GMT, Shawn M Emery <duke at openjdk.org> wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 862:
>>
>>> 860: __ addptr(condensed, condensedOffs);
>>> 861:
>>> 862: if (VM_Version::supports_avx512_vbmi2()) {
>>
>> Which instruction needs vbmi2? All I could spot was that `evpermb` that needs vbmi. Relax the restriction slightly?
>
> Good catch! Initially the code was using `vpshldvw`, but was changed to just use `vpsrlvw`. Fixed in next commit.
> I should probably update the bug synopsis to exclude VBMI2?
I would be happy with just the code being pedantic. Everything else is 'just nice' :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28815#discussion_r2669186665
More information about the security-dev
mailing list