RFR: 8375183: Remove unused SSLConfiguration.maximumProtocolVersion variable
Artur Barashev
abarashev at openjdk.org
Tue Jan 13 14:30:13 UTC 2026
On Tue, 13 Jan 2026 14:15:47 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> "SSLConfiguration.maximumProtocolVersion" is not being used in practice. It's used to initialize "TransportContext.protocolVersion" which is being later set to the negotiated protocol before being ever accessed.
>
> src/java.base/share/classes/sun/security/ssl/TransportContext.java line 147:
>
>> 145: // initial security parameters
>> 146: this.conSession = new SSLSessionImpl();
>> 147: this.protocolVersion = this.sslConfig.maximumProtocolVersion;
>
> Wouldn't this make `protocolVersion` unassigned? I can't see it being set anywhere here, am I missing something?
It will have a default `null` value. It's being assigned to the negotiated protocol outside of this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29192#discussion_r2686665077
More information about the security-dev
mailing list