RFR: 8367024: JNI exception pending in Java_sun_security_pkcs11_wrapper_PKCS11_C_1DeriveKey of p11_keymgmt.c:950 [v2]

[Koushik Muthukrishnan Thirupattur]

On Tue, 13 Jan 2026 21:47:04 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8367024: Addressing review comments
>
> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c line 934:
> 
>> 932:     /* If derivation failed, do not attempt copy-back */
>> 933:     if (ckAssertReturnValueOK(env, rv) != CK_ASSERT_OK) {
>> 934:         jKeyHandle = 0L;
> 
> Why is this needed? `jKeyHandle` is initialized with 0L and no other assignment before this line?

Good catch — jKeyHandle is already initialized. Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29054#discussion_r2688827083