RFR: 8375183: Remove unused SSLConfiguration.maximumProtocolVersion variable
Mikhail Yankelevich
myankelevich at openjdk.org
Wed Jan 14 10:00:53 UTC 2026
On Tue, 13 Jan 2026 20:50:11 GMT, Artur Barashev <abarashev at openjdk.org> wrote:
>> Won't it require additional null checks then? Now it essentially defaults to a max protocol version, which was always present (`ProtocolVersion.NONE` by default)
>
> We don't need null checks, `protocolVersion` currently is not used before it's set to the negotiated protocol, and we'll get a NPE if somebody tries to use it before it's set. It is basically a representation of negotiated protocol in `TransportContext`.
Yeah, I see your point and since it's not supposed to be used uninitialised anyway this way is ok. Thanks for explaining @artur-oracle @djelinski
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29192#discussion_r2689751489
More information about the security-dev
mailing list