RFR: 8374808: Add new methods to KeyStore and KeyStoreSpi that return the creation date as an Instant instead of Date [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Thu Jan 15 10:52:58 UTC 2026
On Wed, 14 Jan 2026 20:51:32 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> src/java.base/share/classes/java/security/KeyStore.java line 1187:
>>
>>> 1185: * Returns the creation date of the entry identified by the given alias.
>>> 1186: * <p>
>>> 1187: * This method returns a Date, which is mutable and more error-prone.
>>
>> Put `Date` in `{@code}`.
>
> I'm a little unsure of the "more" word. When you say more, it sounds like you are comparing it to something else. Since we haven't spelled out the other thing, maybe we can remove this word.
I have replaced this with 'It is recommended to use the {@link #getCreationInstant(String)} method instead.' as per Sean's suggestion
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2693898349
More information about the security-dev
mailing list