RFR: 8374755: ML-KEM's 12-bit decompression uses incorrect assertions [v2]
Andrew Dinn
adinn at openjdk.org
Thu Jan 15 14:34:54 UTC 2026
On Thu, 15 Jan 2026 10:55:50 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix off-by-one error discovered by Shawn
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 6280:
>
>> 6278: vs_st2_post(vs_front(vs_front(vb)), __ T8H, parsed);
>> 6279:
>> 6280: __ BIND(L_end);
>
> This is a substantial change, not a mere matter of "incorrect assertions". Perhaps this PR needs a more appropriate title.
Also, the description in the JIRA and the opening comment in this PR should mention that the intrinsic can be simplified in response to the stricter preconditions maintained by the Java client.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29141#discussion_r2694623478
More information about the security-dev
mailing list