RFR: 8374808: Add new methods to KeyStore and KeyStoreSpi that return the creation date as an Instant instead of Date [v3]

Mikhail Yankelevich myankelevich at openjdk.org
Mon Jan 19 10:18:45 UTC 2026


On Fri, 16 Jan 2026 20:37:20 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   documentation change and truncated instances to millis
>
> src/java.base/share/classes/java/security/KeyStore.java line 1210:
> 
>> 1208:     /**
>> 1209:      * Returns the creation {@code Instant} value
>> 1210:      * of the entry identified by the given alias.
> 
> I would probably rephrase this as "Returns the instant that the entry identified by the given alias was created."
> I don't think you need to put instant in code font as other methods that return instants do not do that.

Done in the next commit, same applies to other comments

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2704108935


More information about the security-dev mailing list