RFR: 8375684: Avoid leak in KeystoreImpl.m when using CFArrayCreateMutable

Christoph Langer clanger at openjdk.org
Thu Jan 22 09:43:13 UTC 2026


On Tue, 20 Jan 2026 16:47:29 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In KeystoreImpl.m we use CFArrayCreateMutable, but we do not always CFRelease the resources we created.
> This should be adjusted.
> 
> See
> https://developer.apple.com/documentation/corefoundation/cfarraycreatemutable(_:_:_:)
> 
> return value is  
> A new mutable array, or NULL if there was a problem creating the object. Ownership follows the [The Create Rule](https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029).

Looks correct.

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29326#pullrequestreview-3691520668


More information about the security-dev mailing list