RFR: 8376218: Improve KeyUtil::getKeySize coverage [v2]

Matthew Donovan mdonovan at openjdk.org
Mon Jan 26 16:44:44 UTC 2026


On Fri, 23 Jan 2026 16:31:58 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Improving `public static final int getKeySize(AlgorithmParameters parameters)` coverage
>
> Mikhail Yankelevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   JDK-8376218: Improve KeyUtil::getKeySize coverage

test/jdk/sun/security/util/KeyUtilTests.java line 58:

> 56: 
> 57:     @Test
> 58:     public void testProvidersAdded() {

Is this just a sanity check?

test/jdk/sun/security/util/KeyUtilTests.java line 84:

> 82:         params.init(ecPrivateKey.getParams());
> 83: 
> 84:         int keySizeResult = KeyUtil.getKeySize(params);

If the `CustomSunEC` provider uses all of the same Service classes as SunEC, what exactly is this test exercising? Seems like it's duplicating `testGetKeySizeSunEc`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29389#discussion_r2728117398
PR Review Comment: https://git.openjdk.org/jdk/pull/29389#discussion_r2728366347


More information about the security-dev mailing list