RFR: 8044609: javax.net.debug options not working and documented as expected [v26]

Bradford Wetmore wetmore at openjdk.org
Wed Jan 28 20:27:09 UTC 2026


On Wed, 28 Jan 2026 04:22:28 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 48 commits:
>> 
>>  - correct NamedGroup.java merge
>>  - Merge branch 'master' into 8044609-ssl
>>  - fix up test bug ID
>>  - fix up files post merge
>>  - Merge branch 'master' into 8044609-ssl
>>  - prep for isOn() merge
>>  - Merge branch 'master' into 8044609-ssl
>>  - Merge branch 'master' into 8044609-ssl
>>  - Merge branch 'master' into 8044609-ssl
>>  - Incorporate review comments from Brad
>>  - ... and 38 more: https://git.openjdk.org/jdk/compare/c69275dd...6b5c692c
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 157:
> 
>> 155:     }
>> 156: 
>> 157:     public static void severe(String msg, Object... params) {
> 
> Since we're down here, these don't really need to be `public`.  Package-private  is fine.

I didn't see this comment (`isOn`/`severe`/`warning`/etc.) addressed?  They are still `public`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2738469785


More information about the security-dev mailing list