Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

[Alan Bateman]

Kelly O'Hair wrote:
>
> Still need reviewer ...
>
>   6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project
>
>   
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ 
>
>
> Pretty harmless code cleanup on the tool used to generate
> some of the JDWP code for the debugger.
>
> -kto
As you say, these changes are harmless but I'm curious as to what is 
generating the warnings. I assume NetBeans is highlighting the unused 
imports and unused fields but the initialization of fields to their 
default values in AbstractNamedNode, AltNode, and others? Is findbugs 
the reason why you are removing the usage of System.exit? As this is a 
command line tool then I would think its usage is justified. The other 
changes look fine except ConstantSetNode.constantMap - can that be final?

The NB project files look fine but just wondering if it is really 
necessary to check in the findbug settings, are there non-default 
settings here?

-Alan