Review request for 6895875: Missing serialVersionUID in sun.management classes

[Alan Bateman]

Mandy Chung wrote:
> With the fix for 6876135, compiling nio pulls in sun.management 
> classes earlier to compile.  make/java/nio/Makefile sets -Xlint:serial 
> -Werror flags that also are passed to javac when compiling 
> sun.management classes that are not serial javac warning free.  I 
> haven't understood completely how sun.management would be pulled to 
> compile due to the other fix that modifies logging.   I need to fix 
> the compilation warnings so that we can push the fix for 6876135 in 
> b76.  When we restructure the source for the modular JDK, we will 
> clean up the compilation dependency.
>
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/6895875/webrev.00/
>
> I added @SuppressWarnings("serial") to the classes that will never be 
> deserialized and added serialVersionUID to the other classes with the 
> serial version output from serialver tool. 
I'll bet that it's j.l.management.PlatformManagedObject that needs to be 
compiled and that is causing JMX and classes in sun.management to be 
compiled. In any case, your changes are fine and are addressing a 
warning that was there anyway. Note that the value for the 
serialVersionUID doesn't really matter so adding a static final 
serialVersionUID = 0L in those internal classes should be fine (instead 
of suppressing the warning).

-Alan.