Review request for 6895875: Missing serialVersionUID in sun.management classes

Mandy Chung Mandy.Chung at Sun.COM
Wed Oct 28 10:22:19 PDT 2009


Alan Bateman wrote:
> I'll bet that it's j.l.management.PlatformManagedObject that needs to 
> be compiled and that is causing JMX and classes in sun.management to 
> be compiled. 

I'm unsure if that's the reason.  j.u.l.LoggingMXBean extends 
j.l.management.PlatformManagedObject before the fix for 6876135.  There 
should be no dependency change as I can see.  I suspect it's related to 
some changesets pushed in the last 2 weeks and this fix happens to 
trigger this build issue.  When I first have the fix for 6876135 ~ 2 
weeks ago, I was able to build my repository successfully but no longer now.

In any case, fixing the warning errors is a good thing.  Unfortunately 
I'm not able to add -Xlint:serial -Werror in 
make/java/management/Makefile as it triggers compilation error in other 
part of the JDK.  I'll file a CR and hopefully one day we have a 
javac-warning-free build.

> In any case, your changes are fine and are addressing a warning that 
> was there anyway. Note that the value for the serialVersionUID doesn't 
> really matter so adding a static final serialVersionUID = 0L in those 
> internal classes should be fine (instead of suppressing the warning).
>
Webrev at:
  http://cr.openjdk.java.net/~mchung/6895875/webrev.01/

Mandy


More information about the serviceability-dev mailing list