Code Review for WeakReference leak in the Logging API (6942989)

Jeremy Manson jeremymanson at google.com
Fri Jun 11 11:55:53 PDT 2010


We also fixed this bug internally at Google (sending the patch out was
a TODO, but we never got around to it).  If you have any interest in
comparing / contrasting approaches, let us know.

Jeremy

On Thu, Jun 10, 2010 at 10:13 AM, Daniel D. Daugherty
<daniel.daugherty at oracle.com> wrote:
> Greetings,
>
> I need a couple of code reviews for my fix for the WeakReference leak
> in the Logging API. The webrev is relative to OpenJDK7, but the bug
> is escalated so the fix will be backported to the JDK6-Update train.
> That's why I need at least two code reviewers.
>
> Here is the URL for the webrev:
>
>   http://cr.openjdk.java.net/~dcubed/6942989-webrev/0/
>
> For some reason, the OpenJDK bug link isn't working which is strange
> considering the bug report came in from forums.java.net.
>
> Thanks, in advance, for any reviews.
>
> Dan
>
>


More information about the serviceability-dev mailing list