code review for CR7007254

Alan Bateman Alan.Bateman at oracle.com
Tue Jan 4 06:05:35 PST 2011


Tomas Hurka wrote:
> Hello,
> I would like to as for review of the fix for CR7007254 - A NullPointerException occurs with jvisualvm placed under a dir. including Japanese chars.
>
> Webrev: http://cr.openjdk.java.net/~thurka/7007254/webrev.00/
>
>   
Tomas - I think the JVMTI spec is for the segment to be specified in 
mUTF-8, in which case I wonder if the JPLIS agent needs changes. I 
remember creating a test to exercise this code in various locales (see 
test/java/lang/instrument/BootClassPath) and I had hoped that it would 
catch any issues like this.

-Alan.


More information about the serviceability-dev mailing list