code review for CR7007254

[Tomas Hurka]

Hi Alan,

On 4 Jan 2011, at 15:05, Alan Bateman wrote:

> Tomas Hurka wrote:
>> Hello,
>> I would like to as for review of the fix for CR7007254 - A NullPointerException occurs with jvisualvm placed under a dir. including Japanese chars.
>> 
>> Webrev: http://cr.openjdk.java.net/~thurka/7007254/webrev.00/
>>  
> Tomas - I think the JVMTI spec is for the segment to be specified in mUTF-8, in which case I wonder if the JPLIS agent needs changes.
You are right, AddToSystemClassLoaderSearch and AddToBootClassLoaderSearch should have segment in mUTF-8. In such case, the fix will be much more complicated. :-(

> I remember creating a test to exercise this code in various locales (see test/java/lang/instrument/BootClassPath) and I had hoped that it would catch any issues like this.
I do not see that this test deploys agent jar via Attach API and tests that agent jar itself is correctly added to system class loader. Note that jar file is added to the bootclasspath correctly, but adding to system class loader is broken.

Bye,
--
Tomas Hurka   <mailto:tomas.hurka at oracle.com>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Developer
Oracle, Praha Czech Republic