SA and JDK ( was Re: JDK8 Preliminary Repository Layout)

[Dr Andrew John Hughes]

On 21 March 2011 22:40, David Holmes <David.Holmes at oracle.com> wrote:
> Hi Andrew,
>
> Dr Andrew John Hughes said the following on 03/22/11 08:09:
>>
>> The first part of a fix for SA is:
>>
>> http://hg.openjdk.java.net/icedtea/jdk7/hotspot/rev/e452443363a7
>>
>> This drops the 1.4 options and gets it building by fixing compareTo.
>> The build doesn't turn on raw type warnings so there aren't any.
>> Instead, you just get the message from javac telling you how to turn
>> them on.
>
> So from our perspective the main impediment to dropping 1.4 is that the SA
> code uses enum as an identifier and so needs to be updated to either change
> names or else change to Java 5 enums. How did you avoid this problem?
>
> David
>
>

Are you sure this use still exists?  I've found no evidence of it when
grepping through the source code and javac compiles the code fine in
source/target 1.6 mode when the compareTo issues are fixed.
The closest I could find is:

src/share/classes/sun/jvm/hotspot/code/Location.java:  // type safe
enum for "Where"
src/share/classes/sun/jvm/hotspot/code/Location.java:  // type safe
enum for "Type"
src/share/classes/sun/jvm/hotspot/code/Location.java:  // constants in Type enum
src/share/classes/sun/jvm/hotspot/code/Location.java:  // constants in
Where enum

which seem to be emulating enums and could be potentially converted to
the 'real thing'.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8