SA and JDK ( was Re: JDK8 Preliminary Repository Layout)

[David Holmes]

Dr Andrew John Hughes said the following on 03/22/11 09:32:
> On 21 March 2011 22:40, David Holmes <David.Holmes at oracle.com> wrote:
>> So from our perspective the main impediment to dropping 1.4 is that the SA
>> code uses enum as an identifier and so needs to be updated to either change
>> names or else change to Java 5 enums. How did you avoid this problem?
> 
> Are you sure this use still exists?  I've found no evidence of it when
> grepping through the source code and javac compiles the code fine in
> source/target 1.6 mode when the compareTo issues are fixed.
> The closest I could find is:
> 
> src/share/classes/sun/jvm/hotspot/code/Location.java:  // type safe
> enum for "Where"
> src/share/classes/sun/jvm/hotspot/code/Location.java:  // type safe
> enum for "Type"
> src/share/classes/sun/jvm/hotspot/code/Location.java:  // constants in Type enum
> src/share/classes/sun/jvm/hotspot/code/Location.java:  // constants in
> Where enum
> 
> which seem to be emulating enums and could be potentially converted to
> the 'real thing'.

Well there is:

./share/classes/sun/jvm/hotspot/debugger/cdbg/basic/BasicEnumType.java: 
  private static class Enum {

but that doesn't cause a problem. Looks like the "institutional memory" 
is out of date on this.

Thanks,
David