Request for review (JVMTI spec, small)

[David Holmes]

Hi Keith,

Keith McGuigan said the following on 05/05/11 11:10:
> There has been a request for us to not link directly to the JVMS from 
> the JVMTI spec (especially using the old location in the java.sun.com 
> domain, which will likely go away someday).  This change removes the 
> hyperlinks to the JVMS from the JVMTI Specification and replaces it with 
> the proper legal name and (when applicable) the chapter number referred 
> to.  I would appreciate any reviews.
> 
> Webrev: http://cr.openjdk.java.net/~kamg/7033669/webrev.00/

There are a couple of places where you use "the <vmspec/>" and so get 
"the The" in the output:

2627             Return the stack showing the <vmspec/>
2707         That is (using the <vmspec/> terminology):
11409       instruction as defined in the <vmspec/>. However, some 
implementations

This one seems to refer to the wrong Chapter/Section - Constant pool 
should be 4.4

*** 13839,13849 ****
         Clarify that stack frames are JVM Spec frames.
         Split can_get_source_info into can_get_source_file_name, 
can_get_line_numbers,
         and can_get_source_debug_extension.
         PopFrame cannot have a native calling method.
         Removed incorrect statement in GetClassloaderClasses
!       (see 
http://java.sun.com/docs/books/vmspec/2nd-edition/html/ConstantPool.doc.html#79383).
     </change>
     <change date="24 July 2003" version="v79">
         XML and text fixes.
         Move stack frame description into Stack Frame category.
     </change>
--- 13807,13817 ----
         Clarify that stack frames are JVM Spec frames.
         Split can_get_source_info into can_get_source_file_name, 
can_get_line_numbers,
         and can_get_source_debug_extension.
         PopFrame cannot have a native calling method.
         Removed incorrect statement in GetClassloaderClasses
!       (see <vmspec chapter="5.3.1"/>).

Otherwise seems fine - though I don't claim to be fluent in xml :)

David