Request for review (JVMTI spec, small)
Keith McGuigan
keith.mcguigan at oracle.com
Thu May 5 05:42:07 PDT 2011
On May 4, 2011, at 11:18 PM, David Holmes wrote:
> Hi Keith,
>
> Keith McGuigan said the following on 05/05/11 11:10:
>> There has been a request for us to not link directly to the JVMS
>> from the JVMTI spec (especially using the old location in the
>> java.sun.com domain, which will likely go away someday). This
>> change removes the hyperlinks to the JVMS from the JVMTI
>> Specification and replaces it with the proper legal name and (when
>> applicable) the chapter number referred to. I would appreciate any
>> reviews.
>> Webrev: http://cr.openjdk.java.net/~kamg/7033669/webrev.00/
>
> There are a couple of places where you use "the <vmspec/>" and so
> get "the The" in the output:
>
> 2627 Return the stack showing the <vmspec/>
> 2707 That is (using the <vmspec/> terminology):
> 11409 instruction as defined in the <vmspec/>. However, some
> implementations
Ok, I'll change these. I was aware of this awkwardness but thought
that since "The Virtual..." was the title, that it made sense to refer
to it as "the <title>", but I suppose these sentences still work okay
without the "the". (dang I did it again!)
> This one seems to refer to the wrong Chapter/Section - Constant pool
> should be 4.4
Good catch - thanks I'll fix that.
--
- Keith
More information about the serviceability-dev
mailing list