RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team

Erik Gahlin erik.gahlin at oracle.com
Fri May 11 07:36:20 PDT 2012


Could you please review? I also need a sponsor.

http://cr.openjdk.java.net/~egahlin/7156518/1_0/

http://monaco.us.oracle.com/detail.jsf?cr=7017818

The patch is for JDK8, but it needs to ported to 7u6 before 5/16.

Thanks!

Erik

Changes:

- Moved localization messages to property files, one message per line, 
as needed.
- Added '&' to messages so mnemonics could be identified.
- Introduced Message class with static fields corresponding to the keys 
in the property files.
- Added map for looking up mnemonics.

Testing:

- Verified programmatically that all the messages and mnemonics are 
"compatible" with the previous mechanism, for Chinese, Japanese and the 
default locale.
- The intention is to run through the GUI to confirm that everything 
looks ok, but I'm waiting for a build.

Other:

- Fixed a typo in the MemoryPoolStat class, the method getAfterGcUsage 
returned this.beforeGCUsage instead of this.afterGcUsage
- When going through all the code I did some minor clean up that should 
not impact the program flow:
   * removed unused imports.
   * inlined temporary variables holding messages.
   * removed private member variables that were not accessed.
   * removed private methods that were not referenced.
   * removed local variables that were not used.
   * added generic types where needed.
   * static methods are now called statically.
   * added suppress serialization warning where it was needed.
   * removed suppress serialization annotation where it was not needed.
- In the Message class, the comment "remove? not found in code" will be 
removed once I know those message are not needed for 7u6.



More information about the serviceability-dev mailing list