RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team

[Michael Fang]

Thanks so much Erik for the fix! The messages.properties file look good. 
I only reviewed the English *messages.properties* file. WPTG will 
re-translate the ja and zh_CN files. They will attempt to leverage 
existing translation from *JConsoleResources_xx.java*.

I have a comments about another translatability rule that WPTG follows:

By Oracle software development guideline, ALL CAPs or StudlyCaps strings 
will not be translated. Examples are:

   19 ACTION_CAPITALIZED=ACTION
   20 ACTION_INFO_CAPITALIZED=ACTION_INFO

  149 MBEAN_INFO=MBeanInfo
  150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo
  151 MBEAN_OPERATION_INFO=MBeanOperationInfo

  206 OBJECT_NAME=ObjectName

  231 R_FORWARD_SLASH_W_CAPITALIZED=R/W

  241 SEQ_NUM=SeqNum

  249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL

  273 UNKNOWN_CAPITALIZED=UNKNOWN


If any of the above such as ACTION or UNKNOWN needs to be translated, 
they should not be ALL CAPS. The translators will not translate those 
lines by default.

The translators have the ability to see comments (or special requests) 
if a comment line is inserted immediately prior to any of the resources 
(each resource string and one comment line immediately before it is 
stored in translation memory). If you must leave ACTION or UNKNOWN in 
CAPS, you can try to insert comments.However, WPTG does not guarantee 
they will be followed.

thanks,

-michael

On 12?05?11? 07:36 ??, Erik Gahlin wrote:
> Could you please review? I also need a sponsor.
>
> http://cr.openjdk.java.net/~egahlin/7156518/1_0/
>
> http://monaco.us.oracle.com/detail.jsf?cr=7017818
>
> The patch is for JDK8, but it needs to ported to 7u6 before 5/16.
>
> Thanks!
>
> Erik
>
> Changes:
>
> - Moved localization messages to property files, one message per line, 
> as needed.
> - Added '&' to messages so mnemonics could be identified.
> - Introduced Message class with static fields corresponding to the 
> keys in the property files.
> - Added map for looking up mnemonics.
>
> Testing:
>
> - Verified programmatically that all the messages and mnemonics are 
> "compatible" with the previous mechanism, for Chinese, Japanese and 
> the default locale.
> - The intention is to run through the GUI to confirm that everything 
> looks ok, but I'm waiting for a build.
>
> Other:
>
> - Fixed a typo in the MemoryPoolStat class, the method getAfterGcUsage 
> returned this.beforeGCUsage instead of this.afterGcUsage
> - When going through all the code I did some minor clean up that 
> should not impact the program flow:
>   * removed unused imports.
>   * inlined temporary variables holding messages.
>   * removed private member variables that were not accessed.
>   * removed private methods that were not referenced.
>   * removed local variables that were not used.
>   * added generic types where needed.
>   * static methods are now called statically.
>   * added suppress serialization warning where it was needed.
>   * removed suppress serialization annotation where it was not needed.
> - In the Message class, the comment "remove? not found in code" will 
> be removed once I know those message are not needed for 7u6.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/e1bdd4e3/attachment-0001.html