RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

Erik Gahlin erik.gahlin at oracle.com
Wed May 30 04:40:47 PDT 2012


Hi,

Could you please review 7172176, which is a test fix for 7017818 -
JConsoleResources.java cannot be handled by translation team.

Webrev:
http://cr.openjdk.java.net/~egahlin/7172176_01/

Changes:

- Removed the ImmutableRequest.java and ImmutableRequest.sh since the
   JConsoleResources class was refactored away with 7017818.

- Removed hard-wired resource bundle keys in ResourceCheckTest.java, the 
keys
   are now looked up by reflection on the Messages class. The test also
   checks there is one-to-one mapping between reource bundle keys and
   the constants available in the Message class.

Michael,

I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/
ProblemList.txt. This means the test will break once the translated files
will be checked in. Unused messages were sent for translation and they
need to be removed.

Are you ok with that?

Thanks!
Erik


More information about the serviceability-dev mailing list