RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

[Tim Bell]

Erik:

Well done - thank you for fixing this!

I apologize for inflicting the original test implementation on 
jconsole.  It is very embarrassing to look at code I wrote eight years ago.

Tim Bell


On 05/30/12 04:40, Erik Gahlin wrote:
> Hi,
>
> Could you please review 7172176, which is a test fix for 7017818 -
> JConsoleResources.java cannot be handled by translation team.
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/7172176_01/
>
> Changes:
>
> - Removed the ImmutableRequest.java and ImmutableRequest.sh since the
>   JConsoleResources class was refactored away with 7017818.
>
> - Removed hard-wired resource bundle keys in ResourceCheckTest.java, 
> the keys
>   are now looked up by reflection on the Messages class. The test also
>   checks there is one-to-one mapping between reource bundle keys and
>   the constants available in the Message class.
>
> Michael,
>
> I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/
> ProblemList.txt. This means the test will break once the translated files
> will be checked in. Unused messages were sent for translation and they
> need to be removed.
>
> Are you ok with that?
>
> Thanks!
> Erik