Review request: 7193302 Remove ConstructorProperties annotation from java.lang.management.LockInfo

[Alan Bateman]

On 11/09/2012 23:40, Mandy Chung wrote:
> :
>
> Webrev at:
>    http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193302/webrev.00/
>
> An existing ThreadMXBeanProxy test verifies the conversion when
> the target VM is running on the same version.  I manually verify
> when a test running on jdk7 connects to a VM running on jdk8 with
> this fix and LockInfo conversion is working properly.
This looks good to me. A minor point but LockInfo should have an @since 
1.8 to make it clear that the from( CompositeData) is new. Also as 
LazyCompositeData is serializable then you may wish to add a 
serialVersionUID to LockInfoCompositeData too (I see the other 
implementations already do this).

Otherwise it is good to hear that 7 <==> 8 interop is not impacted by 
this change.

-Alan
**
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120912/3d4e5b5d/attachment.html