RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Peter Allwin peter.allwin at oracle.com
Thu Nov 14 07:53:06 PST 2013


Hi Staffan, 
84                 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1;
Looks like one more case of this.


Thanks!
/peter


On 14 Nov 2013, at 13:19, Staffan Larsen <staffan.larsen at oracle.com> wrote:

> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/
> 
> On 14 Nov 2013, at 13:12, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> 
>> 
>> On 14 Nov 2013, at 10:46, Weijun Wang <weijun.wang at oracle.com> wrote:
>> 
>>> Also, I am not sure if
>>> 
>>>  int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1;
>>> 
>>> really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses.
>> 
>> Good point. I’ll add parentheses.
>> 
>> /Staffan
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/9a4a27c1/attachment.html 


More information about the serviceability-dev mailing list