RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Staffan Larsen staffan.larsen at oracle.com
Thu Nov 14 10:24:39 PST 2013


Missed that one. I’ll fix it in the same way before pushing.

/Staffan

On 14 Nov 2013, at 16:53, Peter Allwin <peter.allwin at oracle.com> wrote:

> Hi Staffan, 
> 84                 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1;
> Looks like one more case of this.
> 
> 
> Thanks!
> /peter
> 
> 
> On 14 Nov 2013, at 13:19, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> 
>> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/
>> 
>> On 14 Nov 2013, at 13:12, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>> 
>>> 
>>> On 14 Nov 2013, at 10:46, Weijun Wang <weijun.wang at oracle.com> wrote:
>>> 
>>>> Also, I am not sure if
>>>> 
>>>>  int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1;
>>>> 
>>>> really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses.
>>> 
>>> Good point. I’ll add parentheses.
>>> 
>>> /Staffan
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/07b1a839/attachment.html 


More information about the serviceability-dev mailing list