Codereview request: 8025205 Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java

David Holmes david.holmes at oracle.com
Tue Oct 8 18:20:36 PDT 2013


Shanliang writes:
> Hi,
>
> Simply wait longer time for a broken notif.
>
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025205/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8025205

The new loop seems okay - and there is a println to aid in the timeout case.

Not sure about the extra Thread.sleep(1000), seems somewhat ad-hoc, but 
I'm unclear about where these extra notifications might come from or how 
long is a reasonable time to wait to see that there are none. Let's just 
see how this plays out in testing. (I assume you will be keeping a close 
eye on all new results :) ).

Reviewed.

David


More information about the serviceability-dev mailing list