Codereview request: 8025204 Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java
David Holmes
david.holmes at oracle.com
Tue Oct 8 18:28:22 PDT 2013
Shanliang writes:
> Hi,
>
> Simply wait longer time for a broken notif.
>
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025205/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8025205
! // no deadline here, let's wait till either the connId
is removed
! // or the test timeout (jprt kills the test)!
! // see 8025204
The comment loses context if you don't know what the code previously
did. I suggest using the simpler form you used in other tests eg:
// pass or timed out by test harness - see XXXX
Note it isn't JPRT that normally kills these but the jtreg harness.
Style nit:
} while(ids
space needed after 'while'
} while (ids
David
-----
More information about the serviceability-dev
mailing list