Codereview request: 8025204 Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java
shanliang
shanliang.jiang at oracle.com
Wed Oct 9 00:56:18 PDT 2013
David Holmes wrote:
> ! // no deadline here, let's wait till either the
> connId is removed
> ! // or the test timeout (jprt kills the test)!
> ! // see 8025204
>
> The comment loses context if you don't know what the code previously
> did. I suggest using the simpler form you used in other tests eg:
>
> // pass or timed out by test harness - see XXXX
>
> Note it isn't JPRT that normally kills these but the jtreg harness.
>
> Style nit:
>
> } while(ids
>
> space needed after 'while'
>
> } while (ids
Here is the new version integrated your comments:
web: http://cr.openjdk.java.net/~sjiang/8025204jdk/01/
bug: https://bugs.openjdk.java.net/browse/JDK-8025204
Thanks,
Shanliang
>
> David
> -----
More information about the serviceability-dev
mailing list