RFR (M): 8054278: Refactor jps utility tests

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Thu Aug 14 11:52:19 UTC 2014


Hi Katja,

firstly, the webrev contains seemingly unrelated change to 
test/ProblemList.txt - is it correct?

* test/sun/tools/jps/TestJpsClass.java
L33 - typo, JpasBase -> JpsBase

Cheers,

-JB-

On 08/14/2014 01:40 PM, Yekaterina Kantserova wrote:
> Hi,
>
> Could I please have a review of this fix.
>
> webrev:http://cr.openjdk.java.net/~ykantser/8054278/webrev.00/
> bug:https://bugs.openjdk.java.net/browse/JDK-8054278
>
> As of today the test/jdk/sun/tools/jps tests are a number of shell and awk scripts that test only a few combinations of jps args. The tests also used to fail intermittently due to timing issues, e.g.JDK-7091195  <https://bugs.openjdk.java.net/browse/JDK-7091195>  andJDK-6542634  <https://bugs.openjdk.java.net/browse/JDK-6542634>. In order to make tests more stable and make sure all combinations of arguments are tested the test will be refactored using jdk.testlibrary functionality.
>
> The tests have been run on all basic platforms.
>
> Thanks,
> Katja
>



More information about the serviceability-dev mailing list