RFR (M): 8054278: Refactor jps utility tests

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Thu Aug 14 12:01:17 UTC 2014


Jaroslav,

The change in ProblemList is related because 
sun/tools/jps/TestJpsJarRelative.java is failing due to 
https://bugs.openjdk.java.net/browse/JDK-6456333:
=====
With jps -l, full path name is not shown if argument to java -jar is 
relative path name even though jps documentations says: "-l Output the 
full package name for the application’s main class or the full path name 
to the application’s JAR file."
=====
I should mention this, sorry!

// Katja


On 08/14/2014 01:52 PM, Jaroslav Bachorik wrote:
> Hi Katja,
>
> firstly, the webrev contains seemingly unrelated change to 
> test/ProblemList.txt - is it correct?
>
> * test/sun/tools/jps/TestJpsClass.java
> L33 - typo, JpasBase -> JpsBase
>
> Cheers,
>
> -JB-
>
> On 08/14/2014 01:40 PM, Yekaterina Kantserova wrote:
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> webrev:http://cr.openjdk.java.net/~ykantser/8054278/webrev.00/
>> bug:https://bugs.openjdk.java.net/browse/JDK-8054278
>>
>> As of today the test/jdk/sun/tools/jps tests are a number of shell 
>> and awk scripts that test only a few combinations of jps args. The 
>> tests also used to fail intermittently due to timing issues, 
>> e.g.JDK-7091195 <https://bugs.openjdk.java.net/browse/JDK-7091195> 
>> andJDK-6542634 <https://bugs.openjdk.java.net/browse/JDK-6542634>. In 
>> order to make tests more stable and make sure all combinations of 
>> arguments are tested the test will be refactored using 
>> jdk.testlibrary functionality.
>>
>> The tests have been run on all basic platforms.
>>
>> Thanks,
>> Katja
>>
>



More information about the serviceability-dev mailing list