8034856/8034857: More gcc warnings

[Alan Bateman]

On 18/02/2014 03:59, Mikael Vidstedt wrote:
>
> How about:
>
> http://cr.openjdk.java.net/~mikael/webrevs/isspace/webrev.00/webrev/
>
> Cheers,
> Mikael
>
I checked the java.lang.instrument spec and for the Boot-Class-Path 
attribute then it doesn't say any more than "space". It might be worth 
checking the manifest parsing code (parse_manfiest.c) to see how 
continuations are handled as I suspect \r and \n can't appear in the 
attribute value (in which case the check might really only need to be 
for space and \t.

Otherwise replacing isspace is good and your isspaceAscii is likely to 
match the libc isspace (at runtime). This code isn't performance 
sensitive but maybe check space first would be a bit better. Also the 
library native code using 4 space indent rather than hotspot's 2.

I created JDK-8035054 a few days ago to track this. Thanks for taking it 
as I am busy with a number of other things at the moment.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140218/8c866848/attachment.html