RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

Alan Bateman Alan.Bateman at oracle.com
Mon Jan 13 03:33:13 PST 2014


On 13/01/2014 10:40, Yekaterina Kantserova wrote:
> Hi,
>
> Could I please have a review of this fix.
>
> I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in 
> pure Java to get rid of environmental problems. The 
> com/sun/tools/attach tests has already been fixed.
>
>
> Webrev:
> http://cr.openjdk.java.net/~ykantser/6380601/webrev.00/
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-6380601
A minor comment but the location implies that it is a test for jmap or 
jstack so you could use a shorter name for the test if you wish. In 
other areas then we have been using "Basic.java" for the name of basic 
tests.

You might want to check the copyright dates, there should be one year or 
a range (two years) rather than three.

-Alan


More information about the serviceability-dev mailing list