RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Mon Jan 13 05:14:45 PST 2014


Thank you for reviewing this! Yes, I completely agree the tests are 
*very* basic, but I've decided it's more important to fix them as they 
are for the moment. I can open en enhancement that sun tools need more 
tests.

Thanks,
Katja



On 01/13/2014 12:31 PM, Staffan Larsen wrote:
> The changes look good, although the tests are *very* basic. Probably does not make sense to improve the tests as part of this change, though.
>
> /Staffan
>
> On 13 jan 2014, at 11:40, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in pure Java to get rid of environmental problems. The com/sun/tools/attach tests has already been fixed.
>>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ykantser/6380601/webrev.00/
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-6380601
>>
>>
>> Thanks,
>> Katja



More information about the serviceability-dev mailing list